Skip to content

test: standardize all test filenames to _test.py postfix (#760) #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Raja-89 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: standardize all test filenames to _test.py postfix (#760) #889

Raja-89 wants to merge 1 commit into from

Conversation

@Raja-89
Copy link
Contributor

@Raja-89 Raja-89 commented Nov 25, 2025

Standardize all test filenames across tests/unit/ and tests/integration/ to consistently use the _test.py postfix.

This improves test discovery, simplifies CI enforcement, and aligns with the new naming workflow requirements.

Changes included:

  • Rename all unit test files from test_.py → _test.py
  • Rename integration test files that did not already follow _test.py
  • Preserve history using git mv

Ensure no changes are made to helper/config files:

__init__.py

conftest.py

mock_server.py

utils_for_test.py

Updated imports where necessary

Added entry to UNRELEASED changelog

Related issue(s)

Fixes #760

Notes for reviewer

  • All renamed files were moved using git mv to preserve file history.
  • Entire test suite was executed locally — all tests pass.
  • Naming workflow now correctly validates all files.
  • No functional code changes were made; this PR is naming-only.

Checklist

~Documented (changelog entry added)
~Tested (full test suite run locally; naming CI check passes)

@Raja-89
test: standardize all test filenames to _test.py postfix (#ISSUE_NUMBER)
6b42195 
Signed-off-by: Raja Rathour <imraja729@gmail.com>
@exploreriii
Copy link
Contributor

exploreriii commented Nov 25, 2025

Hi @Raja-89 please resolve conflicts 👍
You'll need to rebase
read rebasing.md and merge_conflicts.md please
it looks like your origin may not in line with upstream

@exploreriii
Copy link
Contributor

exploreriii commented Nov 25, 2025

Hi @Raja-89 please get in touch if you need help, see MAINTAINERS.md

exploreriii
exploreriii requested changes Nov 29, 2025
View reviewed changes
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts require fixing - please get in touch if you need help

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Hello, this is the Office Hour Bot.

This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request or receive assistance from a maintainer.

Details:

Disclaimer: This is an automated reminder. Please verify the schedule here to be notified of any changes.

@nadineloepfe
Copy link
Contributor

nadineloepfe commented Dec 3, 2025

Hi @Raja-89 ,
You have a multitude of open PRs. Before opening a new one, could you please finish these ones?
Also, please rebase, as previously mentioned. Thank you!

@nadineloepfe
Copy link
Contributor

nadineloepfe commented Dec 9, 2025

Hi @Raja-89 ,
Please let me know if you still work on any of your 3 PRs or I'll close them. Thank you

@Raja-89
Copy link
Contributor Author

Raja-89 commented Dec 10, 2025

Hi @Raja-89 , Please let me know if you still work on any of your 3 PRs or I'll close them. Thank you

Very sorry , for replying late.
You can take upon this issue
Thanks

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Hi @Raja-89,

This pull request has had no commit activity for 15 days. Are you still working on the issue? please push a commit to keep the PR active or it will be closed due to inactivity.
Reach out on discord or join our office hours if you need assistance.

From the Python SDK Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@exploreriii exploreriii exploreriii requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename test files for consistency

3 participants

@Raja-89 @exploreriii @nadineloepfe